src: abstract tracing agent for both legacy and perfetto#64053
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
legendecas
force-pushed
the
perfetto-tracing-agent
branch
2 times, most recently
from
177f4b9 to
f7a36b9
Compare
legendecas
added
the
trace_events
legendecas
force-pushed
the
perfetto-tracing-agent
branch
5 times, most recently
from
cac4ebe to
49f12cf
Compare
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
force-pushed
the
perfetto-tracing-agent
branch
from
49f12cf to
9d87e1c
Compare
Collaborator
jasnell
approved these changes
Jun 27, 2026
legendecas
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d95cbc2 |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Jul 1, 2026
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: nodejs#64053 Refs: nodejs/diagnostics#654 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make an abstract interface
node::tracing::Agentthat providesgeneral control to the tracing. This allows drop-in replacement
of the legacy trace agent when perfetto is enabled.
This also encapsulates the trace writer to be managed by the
trace agent, instead of the
node::V8Platformmodule, so thatthe
node::V8Platformcould be agnostic about the traceagent implementation.
Refs: nodejs/diagnostics#654